Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds unit test for SessionLifecycleService using the fake registrar i… #5465

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Adds unit test for SessionLifecycleService using the fake registrar i… #5465

merged 2 commits into from
Oct 26, 2023

Conversation

bryanatkinson
Copy link
Contributor

…mplementations

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 20, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (9d548b5) to 63.97% (c6ee9da) by ?.

    26 individual files with coverage change

    FilenameBase (9d548b5)Merge (c6ee9da)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Dispatchers.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?92.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.57%?
    RemoteSettingsFetcher.kt?68.29%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?3.13%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.87%?
    SessionFirelogPublisher.kt?80.49%?
    SessionGenerator.kt?91.67%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?82.67%?
    SessionsActivityLifecycleCallbacks.kt?0.00%?
    SessionsSettings.kt?98.08%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?50.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Xe9dGP8NIn.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Unit Test Results

  30 files  +  8    30 suites  +8   1m 26s ⏱️ +31s
  72 tests +26    72 ✔️ +26  0 💤 ±0  0 ❌ ±0 
144 runs  +52  144 ✔️ +52  0 💤 ±0  0 ❌ ±0 

Results for commit ca15000. ± Comparison against base commit 26ed392.

♻️ This comment has been updated with latest results.

mrober
mrober reviewed Oct 23, 2023
View reviewed changes
firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionLifecycleServiceTest.kt Outdated
}

@Test
@Throws(TimeoutException::class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all these throws annotations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@bryanatkinson bryanatkinson merged commit 4f5da7e into sessions-nine Oct 26, 2023
16 of 20 checks passed
@bryanatkinson bryanatkinson deleted the sessions-service-test-2 branch October 26, 2023 14:52
@firebase firebase locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@jrothfeder jrothfeder Awaiting requested review from jrothfeder

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanatkinson @google-oss-bot @mrober