Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sessions fake registrar #5464

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Sessions fake registrar #5464

merged 3 commits into from
Oct 20, 2023

Conversation

bryanatkinson
Copy link
Contributor

Adds fake implementations for the newly added interfaces and creates a fake registrar installing our fake implementations.

@bryanatkinson
Moves SessionFirelogPublisher and SessionDatastore behind an interfac…
669c6ae 
…e and managed by the Registrar in order to improve testability in the SessionLifecycleService.
@bryanatkinson
Formatting
90c7211
@bryanatkinson
Adds fake implementations of new interfaces and creates a Fake Regist…
cac4d36 
…rar to be used in unit tests.
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

jrothfeder
jrothfeder approved these changes Oct 20, 2023
View reviewed changes
...ssions/src/test/kotlin/com/google/firebase/sessions/testing/FirebaseSessionsFakeRegistrar.kt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow!

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (5c8bf24) to 51.22% (209de7f) by ?.

    26 individual files with coverage change

    FilenameBase (5c8bf24)Merge (209de7f)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Dispatchers.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?92.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.57%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.87%?
    SessionFirelogPublisher.kt?78.05%?
    SessionGenerator.kt?20.83%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionsActivityLifecycleCallbacks.kt?0.00%?
    SessionsSettings.kt?59.62%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tVBa45NA1T.html

@github-actions
Copy link
Contributor

Unit Test Results

22 files  ±0  22 suites  ±0   57s ⏱️ +10s
46 tests ±0  46 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
92 runs  ±0  92 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cac4d36. ± Comparison against base commit 5c8bf24.

@bryanatkinson bryanatkinson merged commit 26ed392 into sessions-nine Oct 20, 2023
@bryanatkinson bryanatkinson deleted the sessions-fake-registrar branch October 20, 2023 21:02
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@mrober mrober Awaiting requested review from mrober

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanatkinson @google-oss-bot @jrothfeder