Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AQS based session ID dependency from Fireperf. #5454

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Remove AQS based session ID dependency from Fireperf. #5454

merged 5 commits into from
Oct 27, 2023

Conversation

visumickey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

Unit Test Results

   110 files   -    802     110 suites   - 802   3m 27s ⏱️ - 35m 30s
   984 tests  - 4 062     984 ✔️  - 4 041  0 💤  - 21  0 ❌ ±0 
1 976 runs   - 8 201  1 976 ✔️  - 8 159  0 💤  - 42  0 ❌ ±0 

Results for commit 2c195bb. ± Comparison against base commit 4d935cd.

♻️ This comment has been updated with latest results.

raymondlam
raymondlam approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@raymondlam raymondlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we just removing the AQS session id mapping for Fireperf events but still sending AQS session events and forwarding performance's collection status?

@visumickey
Copy link
Contributor Author

Are we just removing the AQS session id mapping for Fireperf events but still sending AQS session events and forwarding performance's collection status?

We are trying to make Fireperf not be impacted by AQS changes. Basically, for the multi process fix - we are taking an approach where Fireperf does not get impacted and then bring this change back in Fireperf. So, Fireperf will no longer get the sessionID from AQS until the multi process fix has landed.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from ? (4d935cd) to 70.97% (310d042) by ?.

    104 individual files with coverage change

    FilenameBase (4d935cd)Merge (310d042)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.37%?
    AppStateMonitor.java?85.55%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?93.49%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?76.92%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?28.57%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?89.66%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    Performance.kt?7.14%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.43%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xt7SMlbXnn.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (4d935cd)Merge (310d042)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-perf

    TypeBase (4d935cd)Merge (310d042)Diff
    aar?322 kB? (?)
    apk (aggressive)?1.26 MB? (?)
    apk (release)?3.78 MB? (?)

  • firebase-sessions

    TypeBase (4d935cd)Merge (310d042)Diff
    aar?152 kB? (?)
    apk (aggressive)?373 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CRWYGf8CXr.html

@visumickey visumickey requested a review from mrober October 26, 2023 20:15
@visumickey
Copy link
Contributor Author

/retest

mrober
mrober reviewed Oct 27, 2023
View reviewed changes
firebase-perf/CHANGELOG.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file merged slightly wrong? You're change entry should go under unreleased and 20.5.0 is already out and the Kotlin block got removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed the CHANGELOG to reflect the changes. Is the sessions-nine branch updated? I branched out of that branch.

@visumickey visumickey merged commit b78b7ea into sessions-nine Oct 27, 2023
18 checks passed
@visumickey visumickey deleted the perfRemoveAQS branch October 27, 2023 18:14
@firebase firebase locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@raymondlam raymondlam raymondlam approved these changes

@jrothfeder jrothfeder Awaiting requested review from jrothfeder

@bryanatkinson bryanatkinson Awaiting requested review from bryanatkinson

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @raymondlam @mrober