Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix versions and dependencies for m139 #5453

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@davidmotson davidmotson enabled auto-merge (squash) October 19, 2023 21:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Unit Test Results

  96 files  +  82    96 suites  +82   4m 46s ⏱️ + 4m 6s
324 tests +309  324 ✔️ +309  0 💤 ±0  0 ±0 
648 runs  +618  648 ✔️ +618  0 💤 ±0  0 ±0 

Results for commit 22a71be. ± Comparison against base commit 734462d.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-app-check

    DeviceStatisticsDistributions
    oriole-32
    Percentile734462d869cb82DiffSignificant (?)
    p10460 ±540 μs179 ±45 μs-281 μs (-61.0%)NO
    p25476 ±549 μs193 ±49 μs-284 μs (-59.5%)NO
    p50515 ±564 μs219 ±61 μs-296 μs (-57.4%)NO
    p75557 ±587 μs258 ±58 μs-300 μs (-53.8%)NO
    p90664 ±647 μs337 ±112 μs-327 μs (-49.3%)NO

    20 test runs in comparison
    CommitTest Runs
    734462d
    • 2023-10-19_21:08:57.667671_AKDt
    • 2023-10-19_21:08:57.669489_OfaD
    • 2023-10-19_21:08:57.669509_Stxn
    • 2023-10-19_21:08:57.669518_bFJc
    • 2023-10-19_21:08:57.669525_JgZC
    • 2023-10-19_21:08:57.669532_QrFJ
    • 2023-10-19_21:08:57.669545_RVBi
    • 2023-10-19_21:08:57.669553_EimW
    • 2023-10-19_21:08:57.669560_ULrI
    • 2023-10-19_21:08:57.669566_kWoY
    869cb82
    • 2023-10-19_23:35:53.229143_LDdp
    • 2023-10-19_23:35:53.233459_dhyn
    • 2023-10-19_23:35:53.233477_dVbN
    • 2023-10-19_23:35:53.233484_zdHh
    • 2023-10-19_23:35:53.233491_eUPH
    • 2023-10-19_23:35:53.233498_qTFc
    • 2023-10-19_23:35:53.233509_WeRG
    • 2023-10-19_23:35:53.233515_izie
    • 2023-10-19_23:35:53.233521_OqCi
    • 2023-10-19_23:35:53.233526_AiMR
    redfin-30
    Percentile734462d869cb82DiffSignificant (?)
    p101.75 ±2 ms326 ±70 μs-1.43 ms (-81.4%)NO
    p251.87 ±2 ms352 ±81 μs-1.52 ms (-81.2%)NO
    p502.06 ±3 ms400 ±117 μs-1.66 ms (-80.6%)NO
    p752.31 ±3 ms487 ±221 μs-1.83 ms (-78.9%)NO
    p902.81 ±3 ms654 ±390 μs-2.16 ms (-76.7%)NO

    20 test runs in comparison
    CommitTest Runs
    734462d
    • 2023-10-19_21:08:57.667671_AKDt
    • 2023-10-19_21:08:57.669489_OfaD
    • 2023-10-19_21:08:57.669509_Stxn
    • 2023-10-19_21:08:57.669518_bFJc
    • 2023-10-19_21:08:57.669525_JgZC
    • 2023-10-19_21:08:57.669532_QrFJ
    • 2023-10-19_21:08:57.669545_RVBi
    • 2023-10-19_21:08:57.669553_EimW
    • 2023-10-19_21:08:57.669560_ULrI
    • 2023-10-19_21:08:57.669566_kWoY
    869cb82
    • 2023-10-19_23:35:53.229143_LDdp
    • 2023-10-19_23:35:53.233459_dhyn
    • 2023-10-19_23:35:53.233477_dVbN
    • 2023-10-19_23:35:53.233484_zdHh
    • 2023-10-19_23:35:53.233491_eUPH
    • 2023-10-19_23:35:53.233498_qTFc
    • 2023-10-19_23:35:53.233509_WeRG
    • 2023-10-19_23:35:53.233515_izie
    • 2023-10-19_23:35:53.233521_OqCi
    • 2023-10-19_23:35:53.233526_AiMR
  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentile734462d869cb82DiffSignificant (?)
    p101.13 ±0.8 ms1.03 ±0.8 ms-100 μs (-8.9%)NO
    p251.17 ±0.8 ms1.07 ±0.8 ms-99.6 μs (-8.5%)NO
    p501.26 ±0.8 ms1.19 ±0.8 ms-72.8 μs (-5.8%)NO
    p751.48 ±0.9 ms1.40 ±0.9 ms-82.3 μs (-5.6%)NO
    p901.88 ±1 ms1.75 ±1 ms-127 μs (-6.8%)NO

    20 test runs in comparison
    CommitTest Runs
    734462d
    • 2023-10-19_21:08:57.667671_AKDt
    • 2023-10-19_21:08:57.669489_OfaD
    • 2023-10-19_21:08:57.669509_Stxn
    • 2023-10-19_21:08:57.669518_bFJc
    • 2023-10-19_21:08:57.669525_JgZC
    • 2023-10-19_21:08:57.669532_QrFJ
    • 2023-10-19_21:08:57.669545_RVBi
    • 2023-10-19_21:08:57.669553_EimW
    • 2023-10-19_21:08:57.669560_ULrI
    • 2023-10-19_21:08:57.669566_kWoY
    869cb82
    • 2023-10-19_23:35:53.229143_LDdp
    • 2023-10-19_23:35:53.233459_dhyn
    • 2023-10-19_23:35:53.233477_dVbN
    • 2023-10-19_23:35:53.233484_zdHh
    • 2023-10-19_23:35:53.233491_eUPH
    • 2023-10-19_23:35:53.233498_qTFc
    • 2023-10-19_23:35:53.233509_WeRG
    • 2023-10-19_23:35:53.233515_izie
    • 2023-10-19_23:35:53.233521_OqCi
    • 2023-10-19_23:35:53.233526_AiMR
    redfin-30
    Percentile734462d869cb82DiffSignificant (?)
    p101.55 ±1 ms1.81 ±2 ms+256 μs (+16.5%)NO
    p251.61 ±1 ms1.90 ±2 ms+291 μs (+18.0%)NO
    p501.70 ±1 ms2.02 ±2 ms+323 μs (+19.0%)NO
    p751.86 ±1 ms2.22 ±2 ms+363 μs (+19.6%)NO
    p902.17 ±2 ms2.58 ±2 ms+411 μs (+18.9%)NO

    20 test runs in comparison
    CommitTest Runs
    734462d
    • 2023-10-19_21:08:57.667671_AKDt
    • 2023-10-19_21:08:57.669489_OfaD
    • 2023-10-19_21:08:57.669509_Stxn
    • 2023-10-19_21:08:57.669518_bFJc
    • 2023-10-19_21:08:57.669525_JgZC
    • 2023-10-19_21:08:57.669532_QrFJ
    • 2023-10-19_21:08:57.669545_RVBi
    • 2023-10-19_21:08:57.669553_EimW
    • 2023-10-19_21:08:57.669560_ULrI
    • 2023-10-19_21:08:57.669566_kWoY
    869cb82
    • 2023-10-19_23:35:53.229143_LDdp
    • 2023-10-19_23:35:53.233459_dhyn
    • 2023-10-19_23:35:53.233477_dVbN
    • 2023-10-19_23:35:53.233484_zdHh
    • 2023-10-19_23:35:53.233491_eUPH
    • 2023-10-19_23:35:53.233498_qTFc
    • 2023-10-19_23:35:53.233509_WeRG
    • 2023-10-19_23:35:53.233515_izie
    • 2023-10-19_23:35:53.233521_OqCi
    • 2023-10-19_23:35:53.233526_AiMR
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile734462d869cb82DiffSignificant (?)
    p10205 ±8 ms207 ±3 ms+1.50 ms (+0.7%)NO
    p25211 ±9 ms213 ±4 ms+2.18 ms (+1.0%)NO
    p50219 ±9 ms221 ±4 ms+2.08 ms (+1.0%)NO
    p75228 ±9.6 ms231 ±6 ms+3.70 ms (+1.6%)NO
    p90235 ±10 ms243 ±5 ms+7.48 ms (+3.2%)NO

    20 test runs in comparison
    CommitTest Runs
    734462d
    • 2023-10-19_21:08:57.667671_AKDt
    • 2023-10-19_21:08:57.669489_OfaD
    • 2023-10-19_21:08:57.669509_Stxn
    • 2023-10-19_21:08:57.669518_bFJc
    • 2023-10-19_21:08:57.669525_JgZC
    • 2023-10-19_21:08:57.669532_QrFJ
    • 2023-10-19_21:08:57.669545_RVBi
    • 2023-10-19_21:08:57.669553_EimW
    • 2023-10-19_21:08:57.669560_ULrI
    • 2023-10-19_21:08:57.669566_kWoY
    869cb82
    • 2023-10-19_23:35:53.229143_LDdp
    • 2023-10-19_23:35:53.233459_dhyn
    • 2023-10-19_23:35:53.233477_dVbN
    • 2023-10-19_23:35:53.233484_zdHh
    • 2023-10-19_23:35:53.233491_eUPH
    • 2023-10-19_23:35:53.233498_qTFc
    • 2023-10-19_23:35:53.233509_WeRG
    • 2023-10-19_23:35:53.233515_izie
    • 2023-10-19_23:35:53.233521_OqCi
    • 2023-10-19_23:35:53.233526_AiMR
    redfin-30
    Percentile734462d869cb82DiffSignificant (?)
    p10243 ±5 ms269 ±4 ms+26.6 ms (+10.9%)YES
    p25250 ±5 ms275 ±4 ms+25.0 ms (+10.0%)YES
    p50257 ±5 ms282 ±4 ms+25.6 ms (+10.0%)MAYBE
    p75265 ±6 ms292 ±5 ms+26.7 ms (+10.1%)MAYBE
    p90278 ±8 ms306 ±6 ms+28.8 ms (+10.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    734462d
    • 2023-10-19_21:08:57.667671_AKDt
    • 2023-10-19_21:08:57.669489_OfaD
    • 2023-10-19_21:08:57.669509_Stxn
    • 2023-10-19_21:08:57.669518_bFJc
    • 2023-10-19_21:08:57.669525_JgZC
    • 2023-10-19_21:08:57.669532_QrFJ
    • 2023-10-19_21:08:57.669545_RVBi
    • 2023-10-19_21:08:57.669553_EimW
    • 2023-10-19_21:08:57.669560_ULrI
    • 2023-10-19_21:08:57.669566_kWoY
    869cb82
    • 2023-10-19_23:35:53.229143_LDdp
    • 2023-10-19_23:35:53.233459_dhyn
    • 2023-10-19_23:35:53.233477_dVbN
    • 2023-10-19_23:35:53.233484_zdHh
    • 2023-10-19_23:35:53.233491_eUPH
    • 2023-10-19_23:35:53.233498_qTFc
    • 2023-10-19_23:35:53.233509_WeRG
    • 2023-10-19_23:35:53.233515_izie
    • 2023-10-19_23:35:53.233521_OqCi
    • 2023-10-19_23:35:53.233526_AiMR

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zsPf8w2Rbt/index.html

@davidmotson davidmotson merged commit 4701536 into master Oct 19, 2023
37 checks passed
@davidmotson davidmotson deleted the davidmotson.m139_fixes branch October 19, 2023 23:26
@firebase firebase locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants