Remove passthrough register method from FirebaseSessions since `F…
#5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebaseSessionsDependencies` can be accessed directly.
|
The public api surface has changed for the subproject firebase-sessions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
added 2 commits
October 19, 2023 15:12
Size Report 1Affected Products
Test Logs |
mrober
reviewed
Oct 20, 2023
| @@ -59,6 +59,7 @@ thirdPartyLicenses { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation libs.firebase.sessions | |||
There was a problem hiding this comment.
I don't think we should add sessions like this since we depend on it via implementation(project(':firebase-sessions')) so we can make changes to sessions and crashlytics together easily.
There was a problem hiding this comment.
Yeah, android studio did this for some reason and it works without it. I'm switching to vim.
mrober
reviewed
Oct 20, 2023
firebase-sessions/api.txt
Outdated
| @@ -3,16 +3,50 @@ package com.google.firebase.sessions { | |||
|
|
|||
| public final class FirebaseSessions { | |||
| method @NonNull public static com.google.firebase.sessions.FirebaseSessions getInstance(); | |||
| method @NonNull public static com.google.firebase.sessions.FirebaseSessions getInstance(@NonNull com.google.firebase.FirebaseApp app); | |||
| method public void register(@NonNull com.google.firebase.sessions.api.SessionSubscriber subscriber); | |||
| method @Deprecated @NonNull public static com.google.firebase.sessions.FirebaseSessions getInstance(@NonNull com.google.firebase.FirebaseApp app); | |||
There was a problem hiding this comment.
Do you think we can just remove these instance and getInstance methods? Now there is no useful public api in this class anymore. Maybe even make FirebaseSessions internal. And only the stuff in the api package be public?
mrober
reviewed
Oct 20, 2023
| "data collection enabled: ${subscriber.isDataCollectionEnabled}" | ||
| ) | ||
| } | ||
|
|
||
| /** Calculate whether we should sample events using [sessionSettings] data. */ |
There was a problem hiding this comment.
This comment is left over from an earlier change. Can you delete it since you're already working in this file?
mrober
reviewed
Oct 20, 2023
gradle/libs.versions.toml
Outdated
| @@ -59,6 +59,7 @@ kotest-runner = { module = "io.kotest:kotest-runner-junit4-jvm", version.ref = " | |||
| kotest-assertions = { module = "io.kotest:kotest-assertions-core-jvm", version.ref = "kotest" } | |||
| kotest-property = { module = "io.kotest:kotest-property-jvm", version.ref = "kotest" } | |||
| quickcheck = { module = "net.java:quickcheck", version.ref = "quickcheck" } | |||
| firebase-sessions = { group = "com.google.firebase", name = "firebase-sessions", version = "1.0.2" } | |||
mrober
approved these changes
Oct 20, 2023
bryanatkinson
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…irebaseSessionsDependencies` can be accessed directly.