Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sampling, data collection, and disabled checks to newSession #5451

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add sampling, data collection, and disabled checks to newSession #5451

merged 3 commits into from
Oct 20, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Oct 19, 2023

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (4beb35a) and merge commit (601ba29).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XKC3c88IM6.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

Unit Test Results

0 files   -      81  0 suites   - 81   0s ⏱️ - 2m 59s
0 tests  - 1 039  0 ✔️  - 1 038  0 💤 ±0  0 ❌  - 1 
0 runs   - 1 103  0 ✔️  - 1 102  0 💤 ±0  0 ❌  - 1 

Results for commit b041ee0. ± Comparison against base commit 859cb0c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 19, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (859cb0c)Merge (c62686e)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-installations

    TypeBase (859cb0c)Merge (c62686e)Diff
    aar?58.5 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)

  • firebase-installations-interop

    TypeBase (859cb0c)Merge (c62686e)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-sessions

    TypeBase (859cb0c)Merge (c62686e)Diff
    aar?147 kB? (?)
    apk (aggressive)?372 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iWapSmqbYw.html

jrothfeder
jrothfeder approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@jrothfeder jrothfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me though I think we should rework this a bit. In particular, I don't think we should be querying fields on the subscriber.

@jrothfeder jrothfeder merged commit f75bbf2 into sessions-nine Oct 20, 2023
@jrothfeder jrothfeder deleted the sessions-nine-sampling branch October 20, 2023 19:29
@jrothfeder jrothfeder restored the sessions-nine-sampling branch October 20, 2023 19:29
jrothfeder added a commit that referenced this pull request Oct 20, 2023
@jrothfeder
Revert "Add sampling, data collection, and disabled checks to newSess…
600c2f4 
…ion (#5451)"

This reverts commit f75bbf2.
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryanatkinson bryanatkinson bryanatkinson approved these changes

@jrothfeder jrothfeder jrothfeder approved these changes

Assignees
No one assigned
Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @jrothfeder @bryanatkinson