Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls whether or not the sessions SDK hooks up any lifecycle callb… #5443

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

bryanatkinson
Copy link
Contributor

…acks based on the sdk enablement in SessionsSettings.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (1a70bdc) to 57.99% (82447df) by ?.

    26 individual files with coverage change

    FilenameBase (1a70bdc)Merge (82447df)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?0.00%?
    Dispatchers.kt?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?92.00%?
    FirebaseSessionsRegistrar.kt?74.60%?
    LocalOverrideSettings.kt?100.00%?
    RemoteSettings.kt?88.57%?
    RemoteSettingsFetcher.kt?65.85%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.78%?
    SessionFirelogPublisher.kt?83.33%?
    SessionGenerator.kt?20.83%?
    SessionLifecycleClient.kt?0.00%?
    SessionLifecycleService.kt?0.00%?
    SessionsActivityLifecycleCallbacks.kt?0.00%?
    SessionsSettings.kt?59.62%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.83%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jDaeHqWycd.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Unit Test Results

     81 files  ±0       81 suites  ±0   2m 54s ⏱️ -3s
1 039 tests ±0  1 038 ✔️ ±0  0 💤 ±0  1 ±0 
1 103 runs  ±0  1 102 ✔️ ±0  0 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit 34e72fa. ± Comparison against base commit 1a70bdc.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2023

Size Report 1

Affected Products

  • base

    TypeBase (1a70bdc)Merge (82447df)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)
  • firebase-installations

    TypeBase (1a70bdc)Merge (82447df)Diff
    aar?58.5 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)
  • firebase-installations-interop

    TypeBase (1a70bdc)Merge (82447df)Diff
    aar?8.17 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)
  • firebase-sessions

    TypeBase (1a70bdc)Merge (82447df)Diff
    aar?144 kB? (?)
    apk (aggressive)?371 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7rE7Nrm4Dj.html

…acks based on the sdk enablement in SessionsSettings.
@bryanatkinson bryanatkinson force-pushed the sessions-remote-disable branch from 1fec8f2 to 34e72fa Compare October 18, 2023 20:50
@bryanatkinson bryanatkinson merged commit 859cb0c into sessions-nine Oct 19, 2023
@bryanatkinson bryanatkinson deleted the sessions-remote-disable branch October 19, 2023 13:22
@firebase firebase locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants