Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused methods. #4043

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Clean up unused methods. #4043

merged 1 commit into from
Aug 30, 2022

Conversation

gsakakihara
Copy link
Contributor

  • Cleaned up some unused methods in CommonNotificationBuilder.
  • Also changed to explicitly save the result of sendIntent() in FcmBroadcastProcessor but not use it since we're blocking on the result of the Task, and added a comment to that effect.

@gsakakihara
Clean up unused methods.
3f3dd37 
* Cleaned up some unused methods in CommonNotificationBuilder.
* Also changed to explicitly save the result of sendIntent() in FcmBroadcastProcessor but not use it since we're blocking on the result of the Task, and added a comment to that effect.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022 •
edited
Loading

Unit Test Results

474 tests   - 623   474 ✔️  - 607   3m 44s ⏱️ + 2m 44s
  27 suites  -   52       0 💤  -   16 
  27 files    -   52       0 ❌ ±    0 

Results for commit 3f3dd37. ± Comparison against base commit 42c8d72.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 30, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from ? (42c8d72) to 85.18% (cbeb6e2) by ?.

    41 individual files with coverage change

    FilenameBase (42c8d72)Merge (cbeb6e2)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?76.21%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?82.19%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?80.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?96.08%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

Notes

  • Commit (cbeb6e2) is created by Prow via merging PR base commit (42c8d72) and head commit (3f3dd37).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TIslveMEbK.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (42c8d72)Merge (cbeb6e2)Diff
    aar142 kB142 kB-139 B (-0.1%)
    apk (aggressive)440 kB440 kB+4 B (+0.0%)
    apk (release)1.15 MB1.15 MB-136 B (-0.0%)

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tCJHGQyrvw.html

James201311
James201311 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@James201311 James201311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsakakihara gsakakihara merged commit 46293c9 into master Aug 30, 2022
@gsakakihara gsakakihara deleted the gsakakihara/cleanup branch August 30, 2022 20:13
@firebase firebase locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@James201311 James201311 James201311 approved these changes

@willxu-google willxu-google Awaiting requested review from willxu-google

@welishr welishr Awaiting requested review from welishr

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsakakihara @google-oss-bot @James201311