PR feedback

firebase · Oct 20, 2023 · c24b3de · c24b3de
1 parent 4f06c9d
commit c24b3de
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 23 deletions.
diff --git a/firebase-crashlytics/firebase-crashlytics.gradle b/firebase-crashlytics/firebase-crashlytics.gradle
@@ -59,7 +59,6 @@ thirdPartyLicenses {
 }
 
 dependencies {
-    implementation libs.firebase.sessions
     androidTestImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
     androidTestImplementation "androidx.test:core:$androidxTestCoreVersion"
     androidTestImplementation "com.google.truth:truth:$googleTruthVersion"

diff --git a/firebase-sessions/api.txt b/firebase-sessions/api.txt
@@ -1,21 +1,4 @@
 // Signature format: 2.0
-package com.google.firebase.sessions {
-
-  public final class FirebaseSessions {
-    method @NonNull public static com.google.firebase.sessions.FirebaseSessions getInstance();
-    method @Deprecated @NonNull public static com.google.firebase.sessions.FirebaseSessions getInstance(@NonNull com.google.firebase.FirebaseApp app);
-    property @NonNull public static final com.google.firebase.sessions.FirebaseSessions instance;
-    field @NonNull public static final com.google.firebase.sessions.FirebaseSessions.Companion Companion;
-  }
-
-  public static final class FirebaseSessions.Companion {
-    method @NonNull public com.google.firebase.sessions.FirebaseSessions getInstance();
-    method @Deprecated @NonNull public com.google.firebase.sessions.FirebaseSessions getInstance(@NonNull com.google.firebase.FirebaseApp app);
-    property @NonNull public final com.google.firebase.sessions.FirebaseSessions instance;
-  }
-
-}
-
 package com.google.firebase.sessions.api {
 
   public final class FirebaseSessionsDependencies {

diff --git a/firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt b/firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt
@@ -27,9 +27,8 @@ import kotlin.coroutines.CoroutineContext
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
 
-/** The [FirebaseSessions] API provides methods to register a [SessionSubscriber]. */
-class FirebaseSessions
-internal constructor(
+/** Responsible for initializing AQS */
+internal class FirebaseSessions(
   private val firebaseApp: FirebaseApp,
   private val settings: SessionsSettings,
   backgroundDispatcher: CoroutineContext,
@@ -62,7 +61,6 @@ internal constructor(
     }
   }
 
-  /** Calculate whether we should sample events using [sessionSettings] data. */
   companion object {
     private const val TAG = "FirebaseSessions"
 

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -59,7 +59,6 @@ kotest-runner = { module = "io.kotest:kotest-runner-junit4-jvm", version.ref = "
 kotest-assertions = { module = "io.kotest:kotest-assertions-core-jvm", version.ref = "kotest" }
 kotest-property = { module = "io.kotest:kotest-property-jvm", version.ref = "kotest" }
 quickcheck = { module = "net.java:quickcheck", version.ref = "quickcheck" }
-firebase-sessions = { group = "com.google.firebase", name = "firebase-sessions", version = "1.0.2" }
 
 [bundles]
 kotest = ["kotest-runner", "kotest-assertions", "kotest-property"]