Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Error Message #50

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Improving Error Message #50

merged 2 commits into from
Jul 11, 2017

Conversation

hiranya911
Copy link
Contributor

Adding more information to the error message generated at failed HTTP requests.

Useful when debugging issues like #49

@hiranya911 hiranya911 requested a review from jshcrowthe July 7, 2017 20:51
jshcrowthe
jshcrowthe approved these changes Jul 11, 2017
View reviewed changes
Copy link

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jshcrowthe jshcrowthe assigned hiranya911 and unassigned jshcrowthe Jul 11, 2017
@hiranya911 hiranya911 merged commit 5c14a18 into master Jul 11, 2017
@hiranya911 hiranya911 deleted the hkj-issue-49 branch July 11, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshcrowthe jshcrowthe jshcrowthe approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @jshcrowthe