Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined reCAPTCHA config. #1574

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Defined reCAPTCHA config. #1574

merged 3 commits into from
Feb 14, 2022

Conversation

Xiaoshouzi-gh
Copy link
Contributor

  • Added reCAPTCHA protection states.
  • Added reCAPTCHA action rule.
  • Added reCAPTCHA key config.

No tests needed for this change.

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.

No tests needed for this change.
Copy link

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems better to move the configs to auth-config.ts as other configs there.

src/auth/recaptcha-config.ts Outdated Show resolved Hide resolved
Added reCAPTCHA protection states.
Added reCAPTCHA action rule.
Added reCAPTCHA key config.
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review February 14, 2022 17:52
@lahirumaramba
Copy link
Member

Thanks, @Xiaoshouzi-gh !
LGTM. Before you merge, please get a TW review on the public docs.

Is the plan to update tenant and project config interfaces in a separate PR?

}

/**
* The key's platform type: only web supported now..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fixed extra ..
  • As of the TW review, we were planning to have a TW to do a full review when all pieces in the reCaptcha is ready to be merge into the master branch.
  • Yes, the plan is the update the tenant and project config in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thank you!

@Xiaoshouzi-gh Xiaoshouzi-gh merged commit b300093 into firebase:recaptcha Feb 14, 2022
Xiaoshouzi-gh added a commit that referenced this pull request Mar 2, 2023
* Defined reCAPTCHA config.
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.
Xiaoshouzi-gh added a commit that referenced this pull request Mar 30, 2023
* Defined reCAPTCHA config.
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.
Xiaoshouzi-gh added a commit that referenced this pull request Apr 11, 2023
* Defined reCAPTCHA config.
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.
Xiaoshouzi-gh added a commit that referenced this pull request Apr 12, 2023
* Defined reCAPTCHA config.
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.
Xiaoshouzi-gh added a commit that referenced this pull request Apr 12, 2023
reCAPTCHA support

* Defined reCAPTCHA config. (#1574)
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.

* Create/Update tenant with ReCAPTCHA Config (#1586)

* Support reCaptcha config /create update on tenants.
 - Support create and update tenants with reCaptcha config.
 - Added reCaptcha unit tests on tenants operations.

* Project config - Recaptcha config (#1595)

* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.

* Recapcha integ test (#1599)

* Added integ test for Project Config and Tenants update on reCAPTCHA config

* Account defender support for reCAPTCHA (#1616)

* Support use_account_defender add-on feature for reCAPTCHA config.
* Added integration test for account defender feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants