fix: Limit default ThreadPoolExecutor thread count and remove deadlock scenario
#985
+39
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +84,8 @@ private static class DefaultThreadManager extends GlobalThreadManager { | |||
| protected ExecutorService doInit() { | |||
| ThreadFactory threadFactory = FirebaseScheduledExecutor.getThreadFactoryWithName( | |||
| getThreadFactory(), "firebase-default-%d"); | |||
| return Executors.newCachedThreadPool(threadFactory); | |||
|
|
|||
| return Executors.newFixedThreadPool(100, threadFactory); | |||
| } | |||
There was a problem hiding this comment.
Since a cached thread pool is preferred for short lived tasks, could this introduce any potential performance issues?
There was a problem hiding this comment.
Yes the downside of the this is that threads once created aren't closed until shutdown.
Made a change to add a keepAliveTime for idle threads so this would no longer be the case. I was missing the allowCoreThreadTimeOut() method in testing which allows the timer to be applied.
| } | ||
|
|
||
| private CallableOperation<BatchResponse, FirebaseMessagingException> sendEachOp( | ||
| private ApiFuture<BatchResponse> sendEachOpAsync( |
There was a problem hiding this comment.
This LGTM, but since this more of the opposite of how the rest of the SDK implements async operations, could we add a comment in code or in this thread briefly explaining this change?
lahirumaramba
approved these changes
Aug 30, 2024
| @@ -84,7 +84,8 @@ private static class DefaultThreadManager extends GlobalThreadManager { | |||
| protected ExecutorService doInit() { | |||
| ThreadFactory threadFactory = FirebaseScheduledExecutor.getThreadFactoryWithName( | |||
| getThreadFactory(), "firebase-default-%d"); | |||
| return Executors.newCachedThreadPool(threadFactory); | |||
|
|
|||
| return Executors.newFixedThreadPool(100, threadFactory); | |||
| } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendEachAsync()andsendEachForMulticastAsync()is now avoided by chaining ApiFutures