Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MultiDB Support #723

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Implement MultiDB Support #723

merged 8 commits into from
Oct 21, 2022

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Sep 27, 2022

No description provided.

@tom-andersen tom-andersen requested a review from wu-hui September 28, 2022 12:28
@tom-andersen tom-andersen marked this pull request as ready for review September 28, 2022 12:28
@lahirumaramba lahirumaramba self-requested a review September 29, 2022 21:07
private static synchronized FirestoreClient getInstance(FirebaseApp app) {
/**
* Returns the Firestore instance associated with the default Firebase app. Returns the same
* instance for all invocations. The Firestore instance and all references obtained from it
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all invocations given the same database parameter?

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Oct 3, 2022
@tom-andersen tom-andersen merged commit 1eec932 into master Oct 21, 2022
@lahirumaramba lahirumaramba deleted the tomandersen/multiDb branch November 9, 2022 21:37
@tom-andersen tom-andersen requested a review from markarndt June 12, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants