Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump maven-javadoc-plugin from 3.2.0 to 3.3.0" #569

Conversation

lahirumaramba
Copy link
Member

Reverts #562

It appears that the maven-javadoc-plugin 3.3.0 breaks the build flow in Java 1.7. Reverting this until we come up with a proper solution.
CI error: https://github.com/firebase/firebase-admin-java/runs/2784537466?check_suite_focus=true

@lahirumaramba lahirumaramba requested a review from hiranya911 June 9, 2021 17:31
@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Jun 9, 2021
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

Let's talk about migrating our build workflows to Java 8 in the future.

@lahirumaramba lahirumaramba merged commit 0d7888f into master Jun 9, 2021
@lahirumaramba lahirumaramba deleted the revert-562-dependabot/maven/org.apache.maven.plugins-maven-javadoc-plugin-3.3.0 branch June 9, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants