Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth Javadoc edits #540

Merged
merged 3 commits into from
May 3, 2021
Merged

Auth Javadoc edits #540

merged 3 commits into from
May 3, 2021

Conversation

kevinthecheung
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@kevinthecheung kevinthecheung changed the title Javadoc edits Auth Javadoc edits Apr 30, 2021
@kevinthecheung kevinthecheung requested a review from rsgowman April 30, 2021 22:11
@kevinthecheung kevinthecheung marked this pull request as ready for review April 30, 2021 22:11
@kevinthecheung kevinthecheung merged commit 7352a43 into master May 3, 2021
@kevinthecheung kevinthecheung deleted the kevinthecheung-docstrings branch May 3, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsgowman rsgowman rsgowman approved these changes

Assignees

@kevinthecheung kevinthecheung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinthecheung @rsgowman