Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): enables OIDC auth code flow #532

Merged
merged 6 commits into from
May 11, 2021
Merged

feat(auth): enables OIDC auth code flow #532

merged 6 commits into from
May 11, 2021

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Apr 27, 2021

Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:):

  • id_token
  • code (if set, must also set the client secret)

@lsirac lsirac requested review from hiranya911 and egilmorez April 27, 2021 23:58
@hiranya911 hiranya911 changed the title feat: enables OIDC auth code flow feat(auth): enables OIDC auth code flow May 11, 2021
hiranya911
hiranya911 approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

egilmorez
egilmorez approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@lsirac lsirac merged commit 6962561 into master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@egilmorez egilmorez

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsirac @hiranya911 @egilmorez