fix(fcm): Gracefully handling non-json error responses #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-shao
reviewed
Jan 7, 2021
| @@ -200,14 +200,14 @@ public void testSendErrorWithZeroContentResponse() { | |||
| @Test | |||
| public void testSendErrorWithMalformedResponse() { | |||
| for (int code : HTTP_ERRORS) { | |||
| response.setStatusCode(code).setContent("not json"); | |||
| response.setStatusCode(code).setContent("[not json]"); | |||
There was a problem hiding this comment.
I wonder if a text that looks more like HTML can be more representative here, e.g., <html>"not json"</html> ?
There was a problem hiding this comment.
From my tests and inspection of the JsonParser source, we need more than just HTML tags to trigger this IllegalArgumentException. Square brackets seems to be the easiest and most reliable way. Although it makes me wonder what kind of response was served by FCM to cause this error in the first place.
chong-shao
approved these changes
Jan 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCM service seems to occasionally respond with non-json (HTML) error responses, and if these responses contain certain special characters (e.g.
[or]), the SDK throws a cryptic JSON parse exception (see #506).The
MessagingErrorHandleris supposed to catch all parse errors, but today it only handles IOExceptions thrown by the parser. But in the above case parser throws an IllegalArgumentException. This PR addresses this issue by updating theMessagingErrorHandlerto catch all exceptions thrown by the parser. This makes sure the developer gets aFirebaseMessagingExceptionwith the original error response attached to it, when the above error condition occurs.RELEASE NOTE: Improved support for handling certain non-JSON error responses sent by the FCM backend service.