-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(auth): Added snippets for multitenancy and IdP management #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a couple comments
public void createOidcProviderConfig() throws FirebaseAuthException { | ||
// [START create_oidc_provider] | ||
OidcProviderConfig.CreateRequest request = new OidcProviderConfig.CreateRequest() | ||
.setDisplayName("SAML provider name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.setDisplayName("SAML provider name") | |
.setDisplayName("OIDC provider name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Done.
try { | ||
// idToken comes from the client app | ||
FirebaseToken token = tenantAuth.verifyIdToken(idToken); | ||
// This should be set to TENANT-ID. Otherwise TenantIdMismatch error thrown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clarify what we mean by this
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Snippets for: