Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Added snippets for multitenancy and IdP management #461

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple comments

public void createOidcProviderConfig() throws FirebaseAuthException {
// [START create_oidc_provider]
OidcProviderConfig.CreateRequest request = new OidcProviderConfig.CreateRequest()
.setDisplayName("SAML provider name")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.setDisplayName("SAML provider name")
.setDisplayName("OIDC provider name")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Done.

try {
// idToken comes from the client app
FirebaseToken token = tenantAuth.verifyIdToken(idToken);
// This should be set to TENANT-ID. Otherwise TenantIdMismatch error thrown.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify what we mean by this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hiranya911 hiranya911 merged commit 7b99123 into master Jul 28, 2020
@hiranya911 hiranya911 deleted the hkj-mt-snippets branch July 28, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants