Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6 concurrency support #33

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Swift 6 concurrency support #33

merged 5 commits into from
Oct 29, 2024

Conversation

aashishpatil-g
Copy link
Collaborator

Mark as Sendable,
Synchronized access in Dataconnect instance.

@paulb777 paulb777 requested a review from ncooke3 October 28, 2024 21:12
@ncooke3
Copy link
Member

ncooke3 commented Oct 28, 2024

See firebase/firebase-ios-sdk#13933 for how I worked around the nonisolated errors in old Xcodes.

Sources/DataConnect.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without knowing Swift, I'll still give my LGTM since it looks reasonable to me. Let me know if you need formal approval; otherwise, I'll defer to @ncooke3

@aashishpatil-g aashishpatil-g merged commit 13f249b into main Oct 29, 2024
16 checks passed
@aashishpatil-g aashishpatil-g deleted the ap/marksendable branch October 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants