This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Laboratory work #4, Mashkovtseva Alesia - 22FPL2 #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marina-kaz
reviewed
Dec 12, 2023
lab_4_fill_words_by_ngrams/main.py
Outdated
| @@ -28,6 +32,22 @@ def _tokenize(self, text: str) -> tuple[str, ...]: # type: ignore | |||
| Raises: | |||
| ValueError: In case of inappropriate type input argument or if input argument is empty. | |||
| """ | |||
| if not isinstance(text, str) or not text: | |||
| raise ValueError('Type input is inappropriate or input argument is empty.') | |||
| text = repr(text) | |||
lab_4_fill_words_by_ngrams/main.py
Outdated
| for letter in word: | ||
| if not result or (len(result) > 2 and result[-2] == '.'): | ||
| result += letter.upper() | ||
| else: |
lab_4_fill_words_by_ngrams/main.py
Outdated
| elif generator_type == 1: | ||
| self._generator = TopPGenerator(language_model, word_processor, 0.5) | ||
| elif self._generator_type == 2: | ||
| self._generator = BeamSearchTextGenerator(language_model, word_processor, 5) |
There was a problem hiding this comment.
maybe use dictionary here? to avoid situations when it is not initialized due to wrong input
marina-kaz
reviewed
Dec 14, 2023
|
Well done! Good job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.