This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Laboratory work #4, Tatiana Zheleznova - 22FPL2 #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…исправила стиль кода.
…исправила стиль кода и все ошибки mypy.
…исправила стиль кода и все ошибки mypy.
…исправила стиль кода и все ошибки mypy.
…исправила стиль кода и все ошибки mypy. Надеюсь, убрала ошибку в start.py.
…исправила стиль кода и все ошибки mypy.
artyomtugaryov
suggested changes
Nov 30, 2023
lab_4_fill_words_by_ngrams/main.py
Outdated
| clean_text = '' | ||
| for symbol in new_text.lower(): | ||
| if symbol.isalpha or symbol.isspace() or symbol == self._end_of_word_token: | ||
| clean_text += symbol |
There was a problem hiding this comment.
string concatination is a bad way
There was a problem hiding this comment.
I agree, Artyom from the Past
artyomtugaryov
suggested changes
Dec 7, 2023
lab_4_fill_words_by_ngrams/main.py
Outdated
| @@ -56,6 +74,10 @@ def _postprocess_decoded_text(self, decoded_corpus: tuple[str, ...]) -> str: # | |||
| Raises: | |||
| ValueError: In case of inappropriate type input argument or if input argument is empty. | |||
| """ | |||
| if not isinstance(decoded_corpus, tuple) or not decoded_corpus: | |||
| return ValueError | |||
| decoded_text = ' '.join(decoded_corpus).replace(self._end_of_word_token, '.').capitalize() | |||
There was a problem hiding this comment.
split into 2 lines, please
artyomtugaryov
suggested changes
Dec 14, 2023
lab_4_fill_words_by_ngrams/main.py
Outdated
| clean_text = '' | ||
| for symbol in new_text.lower(): | ||
| if symbol.isalpha or symbol.isspace() or symbol == self._end_of_word_token: | ||
| clean_text += symbol |
There was a problem hiding this comment.
I agree, Artyom from the Past
artyomtugaryov
suggested changes
Dec 17, 2023
|
Well done! Good job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go again