add remove_pub_address, remove_all_pub_addresses to the FIO protocol #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adsorptionenthalpy
approved these changes
Apr 27, 2020
|
Released as part of https://github.com/fioprotocol/fio.contracts/releases/tag/v2.1.0 |
misterleet
pushed a commit
that referenced
this pull request
Jul 15, 2022
Additional OBT and reqeust getter tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new endpoints and fio.address actions for remove_pub_address remove_all_pub_address.
contract actions are readdress remalladdr.
remove all is limited to NOT removing the FIO public address, this decision was made by the product team to eliminate the possibility of not being able to decrypt content in requests associated with the FIO Address.
remove pub address allows the removal of the FIO public address, though this is NOT recommended..
REQUIRED FEES
the remove_pub_address, and remove_all_pub_addresses fees must be added to the launcher. These have been added as a PR to the fio.devtools develop branch, merge this PR before testing these changes or fee errors will result.
TESTING performed..
the SOAPUI tests were run, all testes pass.
a new address was added to the Adam@dapixdev address on a local dev launched FIO blockchain.
this new address was removed using the remove_pub_address call.
the address was re-added.
then remove all pub addresses was run, and the results verified that only the FIO Address remained.
FURTHER TESTING CONSIDERATIONS
2)test error scenarios on both calls, when one or more of the specified addresses do not exist.