Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAS-1653 - Fix type for domain expiration #78

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

adsorptionenthalpy
Copy link
Member

@adsorptionenthalpy adsorptionenthalpy commented Apr 13, 2020

  • Altered domains table type for expiration field to uint64 type
  • Testing: Spun up local test chain with old abi, set contract to new abi and was able to continue registering new fio domains to the table

@adsorptionenthalpy adsorptionenthalpy changed the title MAS-1653 - Fix type for address expiration MAS-1653 - Fix type for domain expiration Apr 13, 2020
@adsorptionenthalpy adsorptionenthalpy merged commit 26ff2ab into develop Apr 13, 2020
@0xCasey 0xCasey deleted the bug/MAS-1653-fioaddress_abichange branch April 17, 2020 21:54
@ericbutz ericbutz added this to the v1.1.0 milestone May 18, 2020
@ericbutz ericbutz modified the milestones: v2.0, Contracts v2.1 Jul 29, 2020
misterleet pushed a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABI error in fio.address, "domains" table: wrong type for "expiration"
3 participants