Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer FIO Domain (MAS-1640 / FIP-1 Part 1) #70

Merged
merged 8 commits into from
Apr 10, 2020
Merged

Transfer FIO Domain (MAS-1640 / FIP-1 Part 1) #70

merged 8 commits into from
Apr 10, 2020

Conversation

0xCasey
Copy link
Member

@0xCasey 0xCasey commented Apr 10, 2020 •
edited
Loading

Add ability to transfer FIO Domain to new owner

  • Adding xferdomain action with associated exception handling
  • Adding /transfer_fio_domain end point
  • Adding new fee: transfer_fio_domain

@0xCasey 0xCasey added enhancement New feature or request improvement labels Apr 10, 2020
@0xCasey 0xCasey self-assigned this Apr 10, 2020
@0xCasey 0xCasey marked this pull request as ready for review April 10, 2020 00:25
@0xCasey 0xCasey closed this Apr 10, 2020
@0xCasey 0xCasey reopened this Apr 10, 2020
@0xCasey 0xCasey requested a review from ericbutz April 10, 2020 00:43
@0xCasey
Copy link
Member Author

0xCasey commented Apr 10, 2020

Local Testing Complete:

./clio -u http://localhost:8889 push action -j fio.address xferdomain '{"fio_domain":"faucet","new_owner_fio_public_key":"FIO6HuPryLfqHnbNVJKb5vJaxi4DhPXLsjn5pYHgGKX99Bg541RDN","max_fee":"4000000000000","actor":"qhh25sqpktwh","tpid":""}' --permission qhh25sqpktwh@active

@0xCasey
Copy link
Member Author

0xCasey commented Apr 10, 2020

Screen Shot 2020-04-10 at 10 15 32 AM

@0xCasey 0xCasey linked an issue Apr 10, 2020 that may be closed by this pull request
Experimenting with domain transfer functionality #41
Closed
@0xCasey 0xCasey merged commit 1458372 into develop Apr 10, 2020
@0xCasey 0xCasey deleted the feature/transfer_domain branch April 17, 2020 21:54
@ericbutz ericbutz added this to the v1.1.0 milestone May 5, 2020
@ericbutz ericbutz modified the milestones: v1.1.0, v1.2.0 May 18, 2020
misterleet pushed a commit that referenced this pull request Jul 15, 2022
@ericbutz
Merge pull request #70 from fioprotocol/eric/xfer-fixes-dev
142780a 
Eric/xfer fixes dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adsorptionenthalpy adsorptionenthalpy adsorptionenthalpy approved these changes

@ericbutz ericbutz ericbutz approved these changes

@edrotthoff edrotthoff Awaiting requested review from edrotthoff

Assignees

@0xCasey 0xCasey

Labels
enhancement New feature or request improvement
Projects
None yet
Milestone
Contracts v2.1
Development

Successfully merging this pull request may close these issues.

Experimenting with domain transfer functionality
3 participants
@0xCasey @adsorptionenthalpy @ericbutz