Fixes for TPID auto proxy, issue 141 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uto_proxy set, pass in the correct auth and use the actor appropriately.
0xCasey
approved these changes
May 22, 2020
…to proxy even when its already in the tpids table. debug out.
0xCasey
approved these changes
May 28, 2020
ericbutz
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes this issue #141
this PR ensures that calls to the update tpid have the correct actor and so the correct entry will be made into the voters table going forward.
this PR requires more intensive testing using TPIDs to verify auto proxy is set up correctly whenever a tpid is used and no proxy is set by the calling account.