Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIP-42] Add regdomadd action #278

Merged
merged 9 commits into from
Jan 5, 2023
Merged

[FIP-42] Add regdomadd action #278

merged 9 commits into from
Jan 5, 2023

Conversation

adsorptionenthalpy
Copy link
Member

First cut at regdomadd action for testing

Registers FIO Domain and Handle together under one action.
FIP-42 - https://github.com/fioprotocol/fips/blob/master/fip-0042.md

@adsorptionenthalpy adsorptionenthalpy changed the title Add regdomadd action - fip42 [FIP-42] Add regdomadd action Oct 26, 2022
ericbutz
ericbutz reviewed Nov 12, 2022
View reviewed changes
contracts/fio.address/fio.address.cpp Outdated Show resolved Hide resolved
contracts/fio.address/fio.address.cpp Outdated Show resolved Hide resolved
contracts/fio.address/fio.address.cpp Outdated Show resolved Hide resolved
contracts/fio.address/fio.address.cpp Show resolved Hide resolved
@ericbutz ericbutz requested a review from bbeale November 12, 2022 17:26
edrotthoff
edrotthoff reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@edrotthoff edrotthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I share Eric’s comment that perhaps the owner account name should be used instead of the actor for account assignments….this is best verified with Adam and pawel.

@adsorptionenthalpy
Copy link
Member Author

Updated actor based on feedback

@adsorptionenthalpy
Don't add a year in December
1664bdd 
BD-4244 Bugfix
- Don't add year in December
- Make years limit bounds checking consistent with number of years
@adsorptionenthalpy adsorptionenthalpy marked this pull request as ready for review December 27, 2022 23:26
@ericbutz ericbutz merged commit 0253770 into develop Jan 5, 2023
@ericbutz ericbutz deleted the dev-adam-fip42 branch January 5, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbutz ericbutz ericbutz approved these changes

@edrotthoff edrotthoff edrotthoff approved these changes

@0xCasey 0xCasey Awaiting requested review from 0xCasey

@bbeale bbeale Awaiting requested review from bbeale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adsorptionenthalpy @edrotthoff @ericbutz