-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-21 -- Implement FIO staking. #124
Merged
ericbutz
merged 34 commits into
develop
from
feature/FIP-21-Staking-fio-contracts-develop-03212021
Jul 13, 2021
Merged
FIP-21 -- Implement FIO staking. #124
ericbutz
merged 34 commits into
develop
from
feature/FIP-21-Staking-fio-contracts-develop-03212021
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
final review of modified FIP, first coding iteration, add global staking state and constants.
comment
add table for accountstake, holding staking info used to compute rewards for each FIO account
fix singleton definition
refactor staking into its own contract.
implement actions called by system
implement fio staking in the staking contract
implement all logic of unstakefio, except the locking.
make fio address parameter to be optional
add adapting of existing general locks.
allow genesis locks and general locks to co exist
fix computation of srp to claim
add staking rewards collection, minting of staking rewards
clean up prints
set the locking periods to be shortened
main net locks to 2 minutes for automated tests
mod the locks to pay out completely during last unlock, address rounding and resolution issues while adapting locks during unstaking
address rounding issues.
on unstake remove expired periods, use period in this same day for unstaking period.
changes to general locks to use amount instead of percetn
Merge develop into dev branch
fix indexing error on order check
change table def fix devnet issue
code brush up handle auto proxy
Closed
fix bug when no tpid specified.
add return status for use with typescript sdk
set to production settings for genesis locking
ericbutz
approved these changes
Jul 13, 2021
Merged
ericbutz
deleted the
feature/FIP-21-Staking-fio-contracts-develop-03212021
branch
February 1, 2023 17:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preliminary and intended to provide developers and other interested parties visibility into the progress of the staking coding effort.
this is DRAFT only until a code review, and security review are performed.
ALL FEEDBACK IS WELCOMED!!!! please add comments or feel free to contact me on telegram or discord.
this PR implements the detailed development specification at
https://fioprotocol.atlassian.net/wiki/spaces/FD/pages/91127818/FIP-21+FIO+Staking+Development+Spec
please refer to the FIP
https://github.com/fioprotocol/fips/blob/master/fip-0021.md