Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tables delete bug in perspective-workspace #946

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix tables delete bug in perspective-workspace #946

merged 1 commit into from
Feb 25, 2020

Conversation

zemeolotu
Copy link
Contributor

@zemeolotu zemeolotu commented Feb 23, 2020 •
edited
Loading

This PR fixes a bug in perspective-workspace where trying to delete a table threw a Maximum call stack size exceeded error

@timkpaine timkpaine added bug Concrete, reproducible bugs JS labels Feb 23, 2020
@texodus texodus force-pushed the workspace-table-fix branch from a62613f to e201021 Compare February 24, 2020 06:05
texodus
texodus approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit cd1a7fb into master Feb 25, 2020
@texodus texodus deleted the workspace-table-fix branch February 25, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemeolotu @texodus @timkpaine @finos-admin