New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor C++ #707

Merged

texodus merged 1 commit into master from cpp-refactor

Sep 5, 2019

Contributor

sc1f commented Sep 5, 2019

Removes unnecessary string copies in emscripten.cpp
Use std::move when possible in constructors for Table, View, and t_view_config
Clarify purpose of filter_op in the view config, and refactor base methods to accept "or" as a valid filter op
clean up filter parsing in emscripten.cpp


          use move semantics for Table, View, t_view_config, fix filter_op +

cd0080b

string copy

finos-admin added the cla-present label

Member

texodus commented Sep 5, 2019

Looks good, thanks for the PR!

texodus merged commit aa32e7c into master

texodus deleted the cpp-refactor branch

September 5, 2019 23:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet