D3fc plugin - "Nearby" tooltips for some charts #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matt-hooper
commented
Mar 14, 2019
- Tooltips for line charts, area charts and canvas based XY scatter using nearby point logic
- Added nearby point logic to Y scatter
- Removed SVG XY scatter chart. Canvas XY scatter is now the default
- Additional refactors and bug-fixes
Get x/y range from plot-area "measure" event Use a generic approach (similar to mainAxis) for getting closest point Added option to existing tooltip component to allow for always-show Added tooltips for canvas scatter chart
New approach to setting xAxis/yAxis lead to a slightly different method for styling the axis too.
The d3fc chart replaces the axis `decorate` function with its own `xDecorate` function, so we need to set that directly.
* Removed old SVG X/Y chart and replace with the Canvas one * Remove old pointSeries
Replaced use of Array.flat "Fixed" `withoutOpacity` function so that it uses "rgb()" instead of "rgba()" Added workaround for weird Edge issue that doesn't render the plot-area of some charts (bar/column charts and heatmap) unless you resize the window. An immediate redraw of the D3 element seems to work, but is not great.
It turns out we don't actually need to use copies of the scales, and therefore can avoid decorating the chart object to get the "measure" (though this approach does require calling the "toolTip" component after the chart has been rendered. This allows us to simplify the code quite a lot. Also: * rebind `settings` and other properties from base tooltip component * added `size` option for controlling highlight sizing (though the "range" has to be modified because the symbol size behaviour isn't the same as the circle radius behaviour) * Use nearby-tooltip for the y-scatter chart, since it's a better experience
|
Thanks for the PR! Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.