[WIP] Move webpack configuration to project root #382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in this issue the focus workspaces features doesn't work at the moment because webpack configuration is part of the
@jpmorganchane\perspective
package.I think this configuration should be moved to the root of the project.
This PR illustrates the change for perspective-viewer only (hence it is a Work In Progress). I've simply taken the various webpack files and pasted them into
scripts\webpack
With these changes, the following now works:
If you're happy with this as an approach, I'll clean up and roll it out across the project.