Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make_table #311

Merged
merged 5 commits into from
Nov 16, 2018
Merged

Refactor make_table #311

merged 5 commits into from
Nov 16, 2018

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Nov 14, 2018

  • Reduce the number of parameters to make_table in cpp
  • Add --source-map-base for emcc, should kick in when source map generation for wasm is fixed
  • Refactor out repetitive lines of code associated with make_table

@texodus texodus merged commit e725ea2 into master Nov 16, 2018
@texodus texodus deleted the parse_data_refactor branch November 16, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants