Fix hidden sort aggregate as unique only when sorted on the same axis
#1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a column which is in a pivot position is also selected as a sort column, but not a visible column, using the default aggregate (
countorsum) will appear to arbitrarily re-order the pivot axis, since this aggregate value is not visible but the pivot value in the row or column header is. Because of this, we always useuniqueas an aggregate when this condition is detected. However, this check previously only checked that such a column was in any pivot position, when really it should only apply to pivots on the same axis as the sort (e.g. row pivots with a hidden sort, or column pivots with a hidden column sort). This PR addresses this issue and adds a test for the case.