Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyterlab tests to CI #1460

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Add Jupyterlab tests to CI #1460

merged 2 commits into from
Jun 29, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Jun 24, 2021

This PR adds a set of Puppeteer tests for perspective-jupyterlab, which assert the basic functionalities of the Jupyterlab widget in a stable and consistent manner.

To run the tests, run yarn test --jupyter with perspective-jupyterlab selected during yarn setup. By default, the tests use the currently set $PYTHONPATH of the shell, which may not resolve to the most up-to-date local build of perspective-python. Simply run the test command with PYTHONPATH set to your local directory, i.e:

PYTHONPATH=./python/perspective:$PYTHONPATH yarn test --jupyter

sc1f added 2 commits June 25, 2021 11:02
Add test:jupyter to perspective-jupyterlab

WIP

rebase onto master, remove docker use for jlab tests
enable all tests

reenable other jobs

rebase and cleanup
@sc1f sc1f changed the title Jupyter tests Add Jupyterlab Tests to CI Jun 25, 2021
@sc1f sc1f changed the title Add Jupyterlab Tests to CI Add Jupyterlab tests to CI Jun 25, 2021
@sc1f sc1f self-assigned this Jun 25, 2021
@sc1f sc1f added internal Internal refactoring and code quality improvement Jupyter labels Jun 25, 2021
@sc1f sc1f marked this pull request as ready for review June 25, 2021 08:31
@texodus
Copy link
Member Author

texodus commented Jun 29, 2021

I've run these quite a few time snow and they seem pretty bulletproof! Nice work!

@texodus
Copy link
Member Author

texodus commented Jun 29, 2021

Thanks for the PR!

@texodus texodus merged commit 7fa3d92 into master Jun 29, 2021
@texodus texodus deleted the jupyter-tests branch June 29, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement Jupyter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants