Fix #1244: make test_wheels script use python -m pip #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@texodus @timkpaine #1244 fixed, as evidenced by this mega-build I kicked off on a test tag: |
timkpaine
approved these changes
Jan 14, 2021
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1244.
The
test_wheelsscript now uses the correct version of pip according to the Python interpreter rather than thepipdefined in$PATH. This caused a [failure] on the 0.6.0 mega-build; even though pip was upgraded, the test script called the wrong version ofpipand caused the wheel import to fail.