Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleable scroll-area for @finos/perspective-viewer-datagrid #1058

Merged
merged 3 commits into from
May 24, 2020

Conversation

texodus
Copy link
Member

@texodus texodus commented May 22, 2020

Reorganizes <perspective-datagrid> DOM structure thusly:

<perspective-viewer>
    <perspective-datagrid>
        <table></table>
    </perspective-datagrid>
</perspective-viewer>

.. with perspective-datagrid element itself acting as the scroll container. This means you should:

  • Listen to scroll events from this element
  • Call its scrollTop to move.
  • Use it to access methods like get_tds().

@texodus texodus closed this May 22, 2020
@texodus texodus deleted the datagrid-refactor-dom branch May 22, 2020 20:53
@texodus texodus restored the datagrid-refactor-dom branch May 22, 2020 20:53
@texodus texodus changed the title Merge initial code from @finos/perspective-viewer-datagrid Styleable scroll-area for @finos/perspective-viewer-datagrid May 22, 2020
@texodus texodus reopened this May 24, 2020
@texodus texodus merged commit 03970d7 into master May 24, 2020
@texodus texodus deleted the datagrid-refactor-dom branch May 24, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants