Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version pulled from package.json too early, ends up 1 version behind dist #616

Closed
timkpaine opened this issue Jun 11, 2019 · 0 comments
Closed

Version pulled from package.json too early, ends up 1 version behind dist #616

timkpaine opened this issue Jun 11, 2019 · 0 comments
Assignees
@sc1f
Labels
bug Concrete, reproducible bugs JS Jupyter

Comments

@timkpaine
Copy link
Member

timkpaine commented Jun 11, 2019 •
edited
Loading

https://github.com/finos/perspective/blob/master/packages/perspective-jupyterlab/src/ts/version.ts#L9

  • replace with looser versioning scheme (minor version)
@timkpaine timkpaine added bug Concrete, reproducible bugs JS Jupyter labels Jun 11, 2019
@timkpaine timkpaine self-assigned this Jun 23, 2019
@texodus texodus assigned sc1f and unassigned timkpaine Jul 29, 2019
texodus added a commit that referenced this issue Jul 30, 2019
@texodus
Merge pull request #675 from finos/fix-jlab-version
4b4b7ea 
Fix #616: perspective-jupyterlab versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc1f sc1f

Labels
bug Concrete, reproducible bugs JS Jupyter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timkpaine @sc1f