Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_index() method missing from Typescript Table type definition #1440

Closed
jmasavaglio opened this issue Jun 8, 2021 · 0 comments
Closed
Assignees
Labels
bug Concrete, reproducible bugs JS

Comments

@jmasavaglio
Copy link

Feature Request

Description of Problem:

I am using perspective with react/typescript and am streaming the table updates via websocket. I am currently unable to get the updates to apply to the index I have set (a unique identitifier), instead it keeps adding more rows and thus have duplicates of all the unique identifiers.

I have updated the index.d.ts in my local environment to include:

get_index(): Promise;

under the Table type definition.

This enables me to obtain the table index and use this code:

const table = await worker.table(server_view, { index: await server_table.get_index() });

Potential Solutions:

If there is no particular reason not to, I propose that the get_index() method is added to the typescript Table type definition file.

If there is a better/preferred way of dealing with this in react/typescript I would be happy to learn that and implement it.

sc1f added a commit that referenced this issue Jun 9, 2021
@sc1f sc1f self-assigned this Jun 9, 2021
@sc1f sc1f added bug Concrete, reproducible bugs JS labels Jun 9, 2021
texodus added a commit that referenced this issue Jun 12, 2021
Output more metadata on expression errors, fix #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

No branches or pull requests

2 participants