Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in the documentation #1056

Closed
mobichel opened this issue May 21, 2020 · 0 comments · Fixed by #1062
Closed

Typo in the documentation #1056

mobichel opened this issue May 21, 2020 · 0 comments · Fixed by #1062
Labels
bug Concrete, reproducible bugs documentation Improvements/bugs/changes to documentation good first issue A relatively simple issue

Comments

@mobichel
Copy link

mobichel commented May 21, 2020 •
edited
Loading

Bug Report

Steps to Reproduce:

Navigate to the documentation page:
https://perspective.finos.org/docs/md/js.html

It says:
Perspective offers these plugin modules: @finos/perspective-viewer-d3fc A custom high-performance data-grid component based on HTML <table>.

Expected Result:

Perspective offers these plugin modules: @finos/perspective-viewer-datagrid A custom high-performance data-grid component based on HTML <table>.
Snigdhabhatnagar added a commit to Snigdhabhatnagar/perspective that referenced this issue May 24, 2020
@Snigdhabhatnagar
Fixed typo on documentation page
7e461d8 
On the documentation page:
It says:
Perspective offers these plugin modules: @finos/perspective-viewer-d3fc A custom high-performance data-grid component based on HTML <table>.

Expected Result:
Perspective offers these plugin modules: @finos/perspective-viewer-datagrid A custom high-performance data-grid component based on HTML <table>.

Resolves finos#1056
@Snigdhabhatnagar Snigdhabhatnagar mentioned this issue May 24, 2020
Merged
@timkpaine timkpaine added bug Concrete, reproducible bugs documentation Improvements/bugs/changes to documentation good first issue A relatively simple issue labels May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs documentation Improvements/bugs/changes to documentation good first issue A relatively simple issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed typo on documentation page Snigdhabhatnagar/perspective
2 participants
@mobichel @timkpaine