-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1529 from finos/fix-settings-persist
Fix `settings` key to trigger redraw + container redraw
- Loading branch information
Showing
7 changed files
with
85 additions
and
36 deletions.
There are no files selected for viewing
38 changes: 19 additions & 19 deletions
38
packages/perspective-viewer-d3fc/test/results/results.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /****************************************************************************** | ||
| * | ||
| * Copyright (c) 2017, the Perspective Authors. | ||
| * | ||
| * This file is part of the Perspective library, distributed under the terms of | ||
| * the Apache License 2.0. The full license can be found in the LICENSE file. | ||
| * | ||
| */ | ||
|
|
||
| const utils = require("@finos/perspective-test"); | ||
|
|
||
| const path = require("path"); | ||
|
|
||
| async function get_contents(page) { | ||
| return await page.evaluate(async () => { | ||
| const viewer = document.querySelector("perspective-viewer").shadowRoot.querySelector("#app_panel"); | ||
| return viewer ? viewer.innerHTML : "MISSING"; | ||
| }); | ||
| } | ||
|
|
||
| utils.with_server({}, () => { | ||
| describe.page( | ||
| "superstore.html", | ||
| () => { | ||
| test.capture("opens settings when field is set to true", async page => { | ||
| await page.evaluate(async () => { | ||
| const viewer = document.querySelector("perspective-viewer"); | ||
| await viewer.getTable(); | ||
| await viewer.restore({settings: true}); | ||
| }); | ||
|
|
||
| return await get_contents(page); | ||
| }); | ||
|
|
||
| test.capture("opens settings when field is set to false", async page => { | ||
| await page.evaluate(async () => { | ||
| const viewer = document.querySelector("perspective-viewer"); | ||
| await viewer.getTable(); | ||
| await viewer.restore({settings: false}); | ||
| }); | ||
|
|
||
| return await get_contents(page); | ||
| }); | ||
| }, | ||
| {root: path.join(__dirname, "..", "..")} | ||
| ); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters