Use locale formatting for all tooltip types (including dates)

The `{style: "decimal"}` option is ignored for non-float types. This gives us a more locale suitable formatting of the date. The test uses the same function to format the date so that it matches.
finos · Apr 4, 2019 · 7fabfb1 · 7fabfb1
1 parent 8e125b3
commit 7fabfb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/perspective-viewer-d3fc/src/js/tooltip/generateHTML.js b/packages/perspective-viewer-d3fc/src/js/tooltip/generateHTML.js
@@ -30,4 +30,4 @@ function addDataValues(tooltipDiv, values) {
         });
 }
 
-const formatNumber = value => (typeof value === "number" ? value.toLocaleString(undefined, {style: "decimal"}) : value);
+const formatNumber = value => value.toLocaleString(undefined, {style: "decimal"});
diff --git a/packages/perspective-viewer-d3fc/test/js/unit/tooltip.js/generateHTML.spec.js b/packages/perspective-viewer-d3fc/test/js/unit/tooltip.js/generateHTML.spec.js
@@ -56,11 +56,12 @@ describe("tooltip should", () => {
 
     test("format mainValue as date", () => {
         settings.mainValues[0].type = "datetime";
+        const testDate = new Date("2019-04-03T15:15Z");
         const data = {
-            mainValue: new Date("2019-04-03T15:15Z").getTime()
+            mainValue: testDate.getTime()
         };
         generateHtml(tooltip, data, settings);
-        expect(getContent()).toEqual(["main-1: Wed Apr 03 2019 16:15:00 GMT+0100 (GMT Summer Time)"]);
+        expect(getContent()).toEqual([`main-1: ${testDate.toLocaleString()}`]);
     });
 
     test("format mainValue as integer", () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,4 +30,4 @@ function addDataValues(tooltipDiv, values) { @@
             });
     }
-    const formatNumber = value => (typeof value === "number" ? value.toLocaleString(undefined, {style: "decimal"}) : value);
+    const formatNumber = value => value.toLocaleString(undefined, {style: "decimal"});