WIP: fix arrow segfaults

finos · May 12, 2020 · 39220c3 · 39220c3
1 parent 1a3bef7
commit 39220c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cpp/perspective/src/cpp/data_table.cpp b/cpp/perspective/src/cpp/data_table.cpp
@@ -413,7 +413,10 @@ t_data_table::append(const t_data_table& other) {
 
     std::set<std::string> incoming;
 
-    for (const auto& cname : other.m_schema.m_columns) {
+    std::cout << "existing schema: " << m_schema << std::endl;
+    std::cout << "schema to append: " << other.m_schema << std::endl;
+
+    for (const auto& cname : m_schema.m_columns) {
         t_dtype col_dtype = get_column(cname)->get_dtype();
         t_dtype other_col_dtype = other.get_const_column(cname)->get_dtype();
         if (col_dtype != other_col_dtype) {

diff --git a/python/perspective/perspective/tests/table/test_update_arrow.py b/python/perspective/perspective/tests/table/test_update_arrow.py
@@ -512,7 +512,6 @@ def test_update_arrow_thread_safe_datetime_index(self, util):
 
         assert tbl.size() == 3
 
-    @mark.skip
     def test_update_arrow_thread_safe_str_index(self, util):
         data = [["a", "b", "c"] for i in range(11)]
         names = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "uid"]