adopt new grammar-JSON transformation API endpoints #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e71aee The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c35dc31 to
3d00891
Compare
a5ac0b6 to
24d02e8
Compare
|
@cla-bot[bot] check |
ef44284 to
cd35af2
Compare
0a066d9 to
39e6589
Compare
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
- Coverage 42.45% 42.43% -0.03%
==========================================
Files 1140 1135 -5
Lines 50247 50250 +3
Branches 11524 11515 -9
==========================================
- Hits 21333 21323 -10
- Misses 28843 28856 +13
Partials 71 71
|
MauricioUyaguari
requested changes
May 23, 2022
| this.setParserError(undefined); | ||
| this.functionElement.body = lambda ? (lambda.body as object[]) : []; | ||
| this.functionElement.body = lambda.body as object[]; |
There was a problem hiding this comment.
did we validate a lambda of empty string works with this ?
MauricioUyaguari
approved these changes
May 23, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
May 31, 2022
…rror in text-mode
7 tasks
MauricioUyaguari
pushed a commit
that referenced
this pull request
Jun 1, 2022
* upgrade Yarn@3.2.1 * fix a regression introduced by #960 where empty grammar causes error in text-mode * eslint: turn off prettier check in CI to speed up lint check * Add CodeQL scan * bump dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #877
Note: we should wait for finos/legend-engine#595 to be merged first
BLOCKERSince it doesn't make sense to forceengineto use the batch ID (the Id of the lambda string in the map of input/payload for batch APIs) assourceId(because in the perspective ofengine,sourceIdrepresents the file, and multiple lambdas can be in the same file, butbatch IDis unique), we can't really make this work with Studio, asStudiorelies on this for compilation to be able to reveal the error, so we would have to discuss with @pierredebelen to see what we could do to makeenginesupport setting thesourceId- resolved in support setting offsetSource Informationfor grammar parser APIs legend-engine#682TEMPORARY__pruneSourceInformationconsistentlyhashLambda->hashRawLambdaTODOwe need to wait for fix NPE exceptions when grammar parser works with external format and relational DB connections legend-engine#692 to make use ofreturnSourceInformationflagHow did you test this change?