Fix a bug with relational mapping tests set with the incorrect database #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb3a1ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
- Coverage 43.64% 43.63% -0.02%
==========================================
Files 904 904
Lines 40301 40309 +8
Branches 9238 9241 +3
==========================================
- Hits 17589 17588 -1
- Misses 22648 22657 +9
Partials 64 64
|
|
@YannanGao-gs Could you elaborate on the context of this bug, what are you aiming to fix? |
akphi
reviewed
Nov 6, 2021
packages/legend-studio/src/stores/editor-state/element-editor-state/mapping/MappingTestState.ts
Outdated
Show resolved
Hide resolved
...components/editor/edit-panel/mapping-editor/InstanceSetImplementationSourceSelectorModal.tsx
Show resolved
Hide resolved
a7abcd6 to
f18a060
Compare
f18a060 to
2f139d4
Compare
MauricioUyaguari
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #649
How did you test this change?
demo.mov