Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow accessing Studio viewer mode using groupId, artifactId, and versionId (GAV coordinates) #639

Merged
merged 14 commits into from
Nov 3, 2021

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Nov 2, 2021

Summary

How did you test this change?

Screen.Recording.2021-11-02.at.4.47.44.PM.mov

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2021

🦋 Changeset detected

Latest commit: 2eeb43b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-dev-utils Patch
@finos/legend-graph Patch
@finos/legend-query Patch
@finos/legend-query-app Patch
@finos/legend-server-depot Patch
@finos/legend-studio Minor
@finos/legend-manual-tests Patch
@finos/legend-studio-app Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-model-storage Patch
@finos/legend-query-deployment Patch
@finos/legend-server-sdlc Patch
@finos/legend-studio-deployment Patch
@finos/legend-tracer-extension-zipkin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@akphi akphi marked this pull request as draft November 2, 2021 05:49
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #639 (2eeb43b) into master (a7ade91) will decrease coverage by 0.03%.
The diff coverage is 20.24%.

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   44.14%   44.10%   -0.04%     
==========================================
  Files         892      893       +1     
  Lines       39649    39704      +55     
  Branches     9050     9059       +9     
==========================================
+ Hits        17504    17513       +9     
- Misses      22086    22132      +46     
  Partials       59       59              
Impacted Files Coverage Δ
...src/components/WebApplicationNavigatorProvider.tsx 0.00% <0.00%> (ø)
...space/src/components/query/DataSpaceQuerySetup.tsx 11.53% <ø> (ø)
...ata-space/src/components/query/DataSpaceViewer.tsx 16.98% <0.00%> (-1.65%) ⬇️
...space/src/stores/query/DataSpaceQuerySetupState.ts 9.09% <0.00%> (-1.01%) ⬇️
...e/packageableElements/mapping/SetImplementation.ts 43.47% <ø> (ø)
...del/packageableElements/mapping/V1_ClassMapping.ts 100.00% <ø> (ø)
...kages/legend-query/src/stores/QueryBuilderState.ts 52.84% <ø> (ø)
...ges/legend-query/src/stores/QueryStoreTestUtils.ts 100.00% <ø> (ø)
packages/legend-server-depot/src/DepotUtils.ts 0.00% <0.00%> (ø)
...ages/legend-server-depot/src/models/ProjectData.ts 0.00% <0.00%> (ø)
... and 14 more

@akphi akphi changed the title DataSpace enterprise view allow accessing Studio viewer mode using groupId, artifactId, and versionId (GAV coordinates) Nov 2, 2021
@akphi akphi marked this pull request as ready for review November 2, 2021 20:52
@akphi
Copy link
Contributor Author

akphi commented Nov 2, 2021

@MauricioUyaguari brought up a good point, we will try to see if there's a way to configure the route in Studio to not require sdlcServerKey. Will address that right after this PR and will also incorporate #149

@akphi akphi marked this pull request as draft November 3, 2021 05:39
@akphi akphi marked this pull request as ready for review November 3, 2021 07:49
@akphi akphi modified the milestone: 2.0.0 Nov 3, 2021
@MauricioUyaguari MauricioUyaguari merged commit 62985e5 into finos:master Nov 3, 2021
@github-actions github-actions bot mentioned this pull request Nov 3, 2021
@akphi akphi deleted the beo branch November 14, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow going to viewer mode using groupId, artifactId, and versionId
2 participants