Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewer for workflow jobs and ability to cancel/rerun and view job logs #632

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Oct 31, 2021

Summary

Adds workflow jobs apis to SDLCServerClient including the ability to cancel and retry jobs, view job logs and run manual jobs.
Adds workflow jobs viewer to view all jobs tied to workflow and each job status including the ability to cancel/retry jobs and view the logs.

Closes #613.

How did you test this change?

N/A

Video Demo

workflow.mov

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2021

🦋 Changeset detected

Latest commit: 88d1c3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@finos/legend-server-sdlc Patch
@finos/legend-studio Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-manual-tests Patch
@finos/legend-query-app Patch
@finos/legend-studio-deployment Patch
@finos/legend-query-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Oct 31, 2021
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #632 (88d1c3f) into master (65bd91e) will decrease coverage by 0.20%.
The diff coverage is 11.67%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   44.35%   44.14%   -0.21%     
==========================================
  Files         892      892              
  Lines       39401    39649     +248     
  Branches     9004     9050      +46     
==========================================
+ Hits        17476    17504      +28     
- Misses      21866    22086     +220     
  Partials       59       59              
Impacted Files Coverage Δ
...ackages/legend-server-sdlc/src/SDLCServerClient.ts 0.58% <0.00%> (-0.08%) ⬇️
.../components/editor/side-bar/WorkspaceWorkflows.tsx 10.61% <10.98%> (+3.21%) ⬆️
...rc/stores/sidebar-state/WorkspaceWorkflowsState.ts 15.38% <13.69%> (-24.62%) ⬇️
...e/element-editor-state/service/ServiceTestState.ts 23.83% <0.00%> (-0.14%) ⬇️

@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review November 1, 2021 14:24
@MauricioUyaguari MauricioUyaguari changed the title WIP: add workflow jobs viewer Workflow jobs viewer Nov 1, 2021
@MauricioUyaguari MauricioUyaguari force-pushed the workflows branch 2 times, most recently from dc52e40 to eecb5d6 Compare November 1, 2021 14:51
@akphi
Copy link
Contributor

akphi commented Nov 1, 2021

@MauricioUyaguari please provide a screenshot/video of what you did for the test section in the PR description? Thanks!

MauricioUyaguari and others added 2 commits November 1, 2021 20:44
Co-authored-by: An Phi <aphi@skidmore.edu>
Co-authored-by: An Phi <aphi@skidmore.edu>
@MauricioUyaguari MauricioUyaguari force-pushed the workflows branch 3 times, most recently from ece2dfe to 884f53a Compare November 2, 2021 14:56
@MauricioUyaguari MauricioUyaguari force-pushed the workflows branch 4 times, most recently from 2849ee3 to 3469dda Compare November 2, 2021 18:51
@MauricioUyaguari MauricioUyaguari changed the title Workflow jobs viewer Add viewer for workflow jobs and ability to cancel/rerun and view job logs Nov 2, 2021
@akphi akphi merged commit a7ade91 into finos:master Nov 2, 2021
@github-actions github-actions bot mentioned this pull request Nov 2, 2021
@MauricioUyaguari MauricioUyaguari deleted the workflows branch November 19, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add WorkflowJobs to Workspace Workflow Panel
2 participants