Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: support loading published query from REPL #3763

Merged
merged 16 commits into from
Dec 31, 2024
Merged

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Dec 23, 2024

(Hosted) DataCube

  • app: support creating new query from multiple sources
  • app: support saving
  • app: support loading existing queries
  • app: support loading query published from REPL
  • infra: reworked engine to support multiple source types
  • infra: improved overall look-n-feel to be consistent with DataCube
  • infra: wired up the basic roundtrip for DataCube
  • infra: introduced a new settings manager (following the idea in RFC: Rework app configuration #407) for DataCube

Screenshots

Publish Query from REPL

Publish.Query.from.REPL.to.Hosted.DataCube.mp4

Create New Query (using a query published from Legend Query)

Create.New.Query.Using.Existing.Saved.Query.as.Source.mp4

Load an Existing Query

Load.Query.mp4

Misc

  • BREAKING CHANGES: standardized naming of grammar parser and composer methods in V1_GraphManagerEngine, i.e. all grammar-to-JSON and JSON-to-grammar methods now have the prefix transform..., and valueSpec is properly spelled out to valueSpecification.
  • infra: add a dummy depot server for ease of local development
  • infra: bump dependencies
   yarn@4.5.0 --> 4.6.0
   @fontsource/jetbrains-mono ------------------ ◯ 5.1.1 -------- ◉ 5.1.2 --------
   @fontsource/raleway ------------------------- ◯ 5.1.0 -------- ◉ 5.1.1 --------
   @fontsource/roboto-condensed ---------------- ◯ 5.1.0 -------- ◉ 5.1.1 --------
   @fontsource/roboto-mono --------------------- ◯ 5.1.0 -------- ◉ 5.1.1 --------
   @fontsource/roboto-serif -------------------- ◯ 5.1.1 -------- ◉ 5.1.2 --------
   @fontsource/roboto -------------------------- ◯ 5.1.0 -------- ◉ 5.1.1 --------
   @fontsource/ubuntu-mono --------------------- ◯ 5.1.0 -------- ◉ 5.1.1 --------
   @mui/material ------------------------------- ◯ 6.2.1 -------- ◉ 6.3.0 --------
   @mui/system --------------------------------- ◯ 6.2.1 -------- ◉ 6.3.0 --------
   @typescript-eslint/eslint-plugin ------------ ◯ 8.18.2 ------- ◉ 8.19.0 -------
   @typescript-eslint/parser ------------------- ◯ 8.18.2 ------- ◉ 8.19.0 -------
   eslint-plugin-react ------------------------- ◯ 7.37.2 ------- ◉ 7.37.3 -------
   lint-staged --------------------------------- ◯ 15.2.11 ------ ◉ 15.3.0 -------
   typedoc ------------------------------------- ◯ 0.27.5 ------- ◉ 0.27.6 -------
   yaml ---------------------------------------- ◯ 2.6.1 -------- ◉ 2.7.0 --------

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 6d4badd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-studio Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-query-builder Patch
@finos/legend-application Patch
@finos/legend-data-cube Patch
@finos/legend-graph Major
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-shared Patch
@finos/legend-art Patch
@finos/legend-server-showcase Patch
@finos/eslint-plugin-legend-studio Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-lego Patch
@finos/legend-code-editor Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-storage Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 5.68273% with 4697 lines in your changes missing coverage. Please review.

Project coverage is 44.55%. Comparing base (3afc9eb) to head (6d4badd).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 493 Missing and 1 partial ⚠️
...s/legend-data-cube/src/stores/DataCubeSettings.tsx 0.00% 420 Missing and 1 partial ⚠️
...ource-builder/LegendQueryDataCubeSourceBuilder.tsx 0.00% 312 Missing and 1 partial ⚠️
...onents/query-builder/LegendDataCubeQueryLoader.tsx 0.00% 309 Missing and 1 partial ⚠️
.../query-builder/LegendDataCubeQueryBuilderStore.tsx 0.00% 295 Missing and 1 partial ⚠️
...s/query-builder/LegendDataCubeQueryLoaderState.tsx 0.00% 257 Missing and 1 partial ⚠️
...ata-cube/src/components/core/DataCubeFormUtils.tsx 0.00% 245 Missing ⚠️
...nents/query-builder/LegendDataCubeQueryBuilder.tsx 0.00% 212 Missing and 1 partial ⚠️
...on-data-cube/src/stores/LegendDataCubeBaseStore.ts 0.00% 197 Missing and 1 partial ⚠️
...cube/src/components/core/DataCubeSettingsPanel.tsx 0.00% 166 Missing ⚠️
... and 105 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3763      +/-   ##
==========================================
- Coverage   44.81%   44.55%   -0.27%     
==========================================
  Files        2229     2236       +7     
  Lines      386386   388781    +2395     
  Branches    16392    16379      -13     
==========================================
+ Hits       173148   173208      +60     
- Misses     212490   214512    +2022     
- Partials      748     1061     +313     
Files with missing lines Coverage Δ
...gend-application-data-cube-bootstrap/src/index.tsx 0.00% <ø> (ø)
...ion-query/src/__lib__/LegendQueryUserDataHelper.ts 88.68% <100.00%> (+0.04%) ⬆️
...ation-studio/src/__lib__/LegendStudioNavigation.ts 59.54% <100.00%> (+1.27%) ⬆️
...editor-group/function-activator/FunctionEditor.tsx 59.25% <100.00%> (ø)
...oup/service-editor/ServiceExecutionQueryEditor.tsx 66.49% <100.00%> (ø)
...studio/src/components/editor/side-bar/Explorer.tsx 73.98% <100.00%> (-1.10%) ⬇️
...ment-editor-state/service/ServiceExecutionState.ts 56.85% <100.00%> (ø)
...be/src/stores/core/DataCubeQuerySnapshotBuilder.ts 98.62% <100.00%> (+0.09%) ⬆️
...data-cube/src/stores/core/models/DataCubeSource.ts 100.00% <100.00%> (ø)
...raph/src/graph-manager/AbstractPureGraphManager.ts 94.04% <100.00%> (+0.08%) ⬆️
... and 123 more

... and 273 files with indirect coverage changes

@akphi akphi force-pushed the dt41 branch 17 times, most recently from 90828b2 to ff5efa1 Compare December 29, 2024 16:17
@akphi akphi force-pushed the dt41 branch 3 times, most recently from 26ab5ee to 5724c0d Compare December 30, 2024 15:24
@akphi akphi marked this pull request as ready for review December 31, 2024 10:03
@akphi akphi requested a review from a team as a code owner December 31, 2024 10:03
@akphi akphi changed the title datacube: rework landing page datacube: hosted app to load published query from REPL Dec 31, 2024
@akphi akphi changed the title datacube: hosted app to load published query from REPL datacube: support loading published query from REPL Dec 31, 2024
@akphi akphi merged commit b023be4 into finos:master Dec 31, 2024
20 checks passed
@akphi akphi deleted the dt41 branch December 31, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants