Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cube Loading to Query Result Panel #3173

Merged

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented May 21, 2024

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 7de9497

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-art Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-manual-tests Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MauricioUyaguari MauricioUyaguari changed the title Add cubes loading indicator Add Cube Loading to Query Result Panel May 21, 2024
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review May 21, 2024 18:40
@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner May 21, 2024 18:40
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 15.71429% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 47.93%. Comparing base (1ce2ea7) to head (7de9497).
Report is 91 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
- Coverage   48.20%   47.93%   -0.27%     
==========================================
  Files        2007     1976      -31     
  Lines      338437   335720    -2717     
  Branches    13019     8435    -4584     
==========================================
- Hits       163139   160935    -2204     
+ Misses     174989   174785     -204     
+ Partials      309        0     -309     
Files Coverage Δ
.../src/components/result/QueryBuilderResultPanel.tsx 65.68% <100.00%> (-0.54%) ⬇️
packages/legend-art/src/index.ts 0.00% <0.00%> (ø)
...es/legend-art/src/loader/CubesLoadingIndicator.tsx 0.00% <0.00%> (ø)

... and 260 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit 052f22e into finos:master May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants