Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REPL base url to allow hosting it on proxy environments #3169

Merged
merged 1 commit into from
May 21, 2024

Conversation

rafaelbey
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@rafaelbey rafaelbey requested a review from a team as a code owner May 21, 2024 16:04
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 7ba4db6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@finos/legend-application-repl-deployment Patch
@finos/legend-application-repl Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 47.96%. Comparing base (1ce2ea7) to head (7ba4db6).
Report is 88 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3169      +/-   ##
==========================================
- Coverage   48.20%   47.96%   -0.25%     
==========================================
  Files        2007     1975      -32     
  Lines      338437   335659    -2778     
  Branches    13019    12767     -252     
==========================================
- Hits       163139   160984    -2155     
+ Misses     174989   174675     -314     
+ Partials      309        0     -309     
Files Coverage Δ
...tion-repl/src/application/LegendREPLGridClient.tsx 0.00% <0.00%> (ø)
...s/legend-application-repl-deployment/src/index.tsx 0.00% <0.00%> (ø)

... and 256 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit 61d0311 into finos:master May 21, 2024
13 checks passed
@rafaelbey rafaelbey deleted the repl_base_url_fix branch May 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants