Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor query fixes #3162

Merged
merged 3 commits into from
May 19, 2024
Merged

minor query fixes #3162

merged 3 commits into from
May 19, 2024

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented May 18, 2024

Summary

  • fix show pure to be readOnly and add copyToClipBoard option
  • change pure options to Show Pure , Show Protocol, and Edit Pure
  • hide exec context if only one in dataspace

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented May 18, 2024

🦋 Changeset detected

Latest commit: 1d25f59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-studio Patch
@finos/legend-application-query Patch
@finos/legend-query-builder Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-manual-tests Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MauricioUyaguari MauricioUyaguari changed the title fix show pure to be readonly minor fixes May 18, 2024
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review May 18, 2024 21:42
@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner May 18, 2024 21:42
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 42.00000% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 48.00%. Comparing base (1ce2ea7) to head (1d25f59).
Report is 84 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3162      +/-   ##
==========================================
- Coverage   48.20%   48.00%   -0.20%     
==========================================
  Files        2007     1975      -32     
  Lines      338437   335388    -3049     
  Branches    13019    12737     -282     
==========================================
- Hits       163139   161010    -2129     
+ Misses     174989   174080     -909     
+ Partials      309      298      -11     
Files Coverage Δ
...ery-builder/src/components/QueryBuilderSideBar.tsx 90.82% <100.00%> (+27.14%) ⬆️
...lication-studio/src/components/ShowcaseManager.tsx 11.78% <50.00%> (+0.12%) ⬆️
...or/editor-group/database/IsolatedQueryDatabase.tsx 26.81% <83.33%> (ø)
...src/stores/explorer/QueryFunctionsExplorerState.ts 55.55% <83.33%> (+0.46%) ⬆️
.../src/components/data-space/DataSpaceQuerySetup.tsx 0.00% <0.00%> (ø)
...group/connection-editor/DatabaseSchemaExplorer.tsx 26.69% <33.33%> (+0.37%) ⬆️
...der/src/components/workflows/ClassQueryBuilder.tsx 0.00% <0.00%> (ø)
...r/src/components/workflows/MappingQueryBuilder.tsx 0.00% <0.00%> (ø)
...gend-query-builder/src/components/QueryBuilder.tsx 77.57% <75.00%> (-0.32%) ⬇️
...r/src/components/workflows/ServiceQueryBuilder.tsx 0.00% <0.00%> (ø)
... and 3 more

... and 154 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari changed the title minor fixes minor query fixes May 18, 2024
@akphi akphi merged commit ef8410a into finos:master May 19, 2024
13 checks passed
@akphi akphi deleted the minor branch May 19, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants